Make sure locals_max_{length,string} work as expected in case they are None #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh4pe
force-pushed
the
fix/exception-dict-transformer-type-error
branch
from
d124c51 to
cab20c7
Compare
|
Uhm, what about the pre-commit check? What is wrong there? |
hynek
reviewed
Nov 29, 2024
| ) | ||
| def test_exception_dict_transformer_locals_max_accept_none_argument( | ||
| kwargs, local_variable | ||
| ): |
There was a problem hiding this comment.
Sorry for the late response! The CI is failing because your test doesn't have a docstring in the form of https://jml.io/test-docstrings/
There was a problem hiding this comment.
Alright, got it, thanks. I tried to add a suitable docstring, hope that suffices.
Sh4pe
force-pushed
the
fix/exception-dict-transformer-type-error
branch
from
cab20c7 to
d86f1c3
Compare
Sh4pe
force-pushed
the
fix/exception-dict-transformer-type-error
branch
from
d86f1c3 to
79297cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case where truncation or abbreviation in
ExceptionDictTransformeris disabled usinglocals_max_lengthorlocals_max_string.Closes #672.