Version 0.2.0 proposal #11
Conversation
…w throw an IllegalArgumentException if the provided schematic is of unknown type
…s via a lookup table
…dit & Sponge schematic implementations
…would produce an out of bounds exception
… it can be chained
This reverts commit c826039.
…l documentation is finished
|
you madman |
yeah i might've gotten a bit carried away lmao |
.gitignore
Outdated
| # .idea/artifacts | ||
| # .idea/compiler.xml | ||
| # .idea/jarRepositories.xml | ||
| # .idea/modules.xml | ||
| # .idea/*.iml | ||
| # .idea/modules | ||
| # *.iml | ||
| # *.ipr |
There was a problem hiding this comment.
This stuff should be uncommented.
.gitignore
Outdated
| ### Let's just ignore the whole .idea folder for now### | ||
| .idea/ |
scaffolding-core/build.gradle.kts
Outdated
| compileOnly("com.github.Minestom:Minestom:${minestomVersion}") | ||
| testImplementation("com.github.Minestom:Minestom:${minestomVersion}") | ||
|
|
||
| testImplementation("me.alexpanov:free-port-finder:1.1.1") |
There was a problem hiding this comment.
Should probably just use port 25565 for convenience sake.
| /** | ||
| * A static utility class primarily used to parse schematics. | ||
| */ | ||
| @SuppressWarnings("unused") |
There was a problem hiding this comment.
Warnings probably shouldn't be suppressed. Unused is a valid thing to supress but I prefer keeping warnings in.
There was a problem hiding this comment.
You're right. If I ever get around to adding proper unit tests suppressing unused warnings won't be necessary. I'll remove them.
| /** | ||
| * Represents a rectangle 3 dimensional region of blocks withing an {@link Instance}. | ||
| */ | ||
| @SuppressWarnings("unused") |
There was a problem hiding this comment.
Same suppressing thing here.
scaffolding-editor/build.gradle.kts
Outdated
| dependencies { | ||
| implementation(project(":scaffolding-core")) | ||
|
|
||
| implementation("me.alexpanov:free-port-finder:1.1.1") |
There was a problem hiding this comment.
Should also probably use 25565
…5 by default (also formatting improvements)
|
Should the server have Moulberry's WorldEdit installed by default instead of recreating a selection tool? It should allow the end user to have more editing capability. |
|
I thought about that. I'm a bit torn on the issue. One one hand, leveraging the 10+ years of development that WE has is a smart move. On the other, I think with enough work it would be possible to surpass the capabilities of what WE has to offer. I personally would like to go down the second route, but if you want me to cut the editor in favor of using WE I understand. |
|
If you have the time and dedication to do that, go ahead. I'm unable to spend that time unfortunately. |
|
Hey @DamianKocher, thank you for contributing, I am able to work on this in my free time so I will be merge this into a development branch to continue. |
This PR fixes many issues but probably creates many more. I believe these changes are necessary to reach a point where this library can be used in a production capacity.
Fixes
Fixes #4 - Scaffolding methods now cannot return null
Fixes #8 - Schematics now cannot be placed in positions which would put them outside of world bounds
Fixes #10 - MCEdit schematics now use correct block palette
Improvements