How to either create a hyper::Error or handle hyper::http::Error #2802

ristillu · 2022-03-31T13:44:16Z

ristillu
Mar 31, 2022

Let's say I have code like this:

fn bad_request() -> Result<Response<Body>> {
    Ok(Response::builder()
            .status(StatusCode::BAD_REQUEST)
            .body(Body::empty())?)
}

This fails to compile with From<hyper::http::Error> is not implemented for hyper::Error. It feels to me that it would make sense if it was? Any suggestions what I can do about it? I mean, I can unwrap() but I'd rather map_err (in other analogous but way more extensive code) creating a hyper::Error myself. But I can't do that because the details are private. Or I could implement my own error handling, but I'd rather use what feels so close. I.e. my best case solution would be if From was implemented.

Answered by seanmonstar

Mar 31, 2022

A hyper::Error is not meant to be something that a user creates. You don't need to return one in your server handler. I imagine you probably want to because you also are handling request body errors? Here's what I would do: change your service error to a dynamic error type. Maybe anyhow, or even just Box<dyn std::error::Error>.

View full answer

seanmonstar · 2022-03-31T14:38:46Z

seanmonstar
Mar 31, 2022
Maintainer

A hyper::Error is not meant to be something that a user creates. You don't need to return one in your server handler. I imagine you probably want to because you also are handling request body errors? Here's what I would do: change your service error to a dynamic error type. Maybe anyhow, or even just Box<dyn std::error::Error>.

0 replies

ristillu · 2022-04-01T07:59:11Z

ristillu
Apr 1, 2022
Author

Thanks Sean. My n00b-ness showing through. I've previously shied away from those two approaches, trying to roll my own as I learn better how Rust works. But I've seen enough of both suggestions before that it's probably high time to try them.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

How to either create a hyper::Error or handle hyper::http::Error #2802

{{title}}

Replies: 2 comments

{{title}}

{{title}}

Select a reply

How to either create a hyper::Error or handle hyper::http::Error #2802

ristillu Mar 31, 2022

Replies: 2 comments

seanmonstar Mar 31, 2022 Maintainer

ristillu Apr 1, 2022 Author

ristillu
Mar 31, 2022

seanmonstar
Mar 31, 2022
Maintainer

ristillu
Apr 1, 2022
Author