You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, the status fields of the returned Output structs are not checked. So if either command completes with a non-zero exit code, it will go unnoticed.
Moreover, Command::output has the unfortunate side effect of capturing the output, i.e., stdout and stderr are not forwarded to the terminal. So if an error occurs, it could be hidden.
Would you consider a PR to check the commands' statuses?
The text was updated successfully, but these errors were encountered:
The build scripts use
Command::output
to runmake
andllvm-config
:solang/build.rs
Lines 8 to 17 in 32a45ea
However, the
status
fields of the returnedOutput
structs are not checked. So if either command completes with a non-zero exit code, it will go unnoticed.Moreover,
Command::output
has the unfortunate side effect of capturing the output, i.e., stdout and stderr are not forwarded to the terminal. So if an error occurs, it could be hidden.Would you consider a PR to check the commands' statuses?
The text was updated successfully, but these errors were encountered: