[Renderer] Shadowmaps flashlight bugged in multiplayer

[di57inct]

EDIT: https://youtu.be/TzCqgphlLG0

https://youtu.be/0M8TsI5MSe0
As you can see in the chat, EF_DIMLIGHT is present, but the flashlight doesn't show either for me or for the other players.

https://www.youtube.com/watch?v=ZGxpE8eHjxI
In this second clip, you can see at the beginning that my flashlight appears, but at a fixed origin and angle.

Somehow, it only wants to work on certain maps and map zones. When it works, the fps drops drastically:

[hzqst]

Root cause

Valve uses exact the same key (key=4) for any dynamic light emitted from player with EF_DIMLIGHT

//cl_ents.c from hw.dll

		if ( j != cl.viewentity - 1 )
		{
			if (ent->curstate.effects & EF_BRIGHTLIGHT)
			{
				dl = efx.CL_AllocDlight (4);
				VectorCopy (ent->origin, dl->origin);
				dl->origin[2] += 16;
				dl->color.r = dl->color.g = dl->color.b = 250;
				dl->radius = RandomFloat(400,431);
				dl->die = cl.time + 0.001;
			}
			if (ent->curstate.effects & EF_DIMLIGHT)
			{
				dl = efx.CL_AllocDlight (4);
				VectorCopy (ent->origin, dl->origin);
				dl->color.r = dl->color.g = dl->color.b = 100;
				dl->radius = RandomFloat(200,231);
				dl->die = cl.time + 0.001;
			}
		}

		ClientDLL_AddEntity( ET_PLAYER, ent );
	}

	CL_PlayerFlashlight();

thus only one flashlight from a non-local-player will be effective at the same time.

Let's fuck Valve.

Possible mitigation

maybe change 4 to sth. like 0x40000+j as j is the playerindex then everyone will not share a unique dlight between each others anymore.

Fix

https://github.com/hzqst/MetaHookSv/releases/tag/v20250130a

[di57inct]

Crashes instantly when i try to turn on the flashlight

[hzqst]

Crashes instantly when i try to turn on the flashlight

try https://github.com/hzqst/MetaHookSv/releases/tag/v20250131a

[hzqst]

still not working?

[di57inct]

didn't get a chance to test it haven't used the pc for 4 days. will reply after i do it.