Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #109

Closed
develop7 opened this issue Feb 13, 2024 · 1 comment
Closed

Windows support #109

develop7 opened this issue Feb 13, 2024 · 1 comment

Comments

@develop7
Copy link
Contributor

The h-o-sdk package depends on unix, preventing it to build on Windows, while, at first glance, only unix-specific functions it seems to use are getProcessID (present in unix-compat-0.7.1) and getEffectiveUserName (a no-op on Windows?).
@develop7 develop7 mentioned this issue Feb 13, 2024
Open
10 tasks
develop7 added a commit to develop7/hs-opentelemetry that referenced this issue Mar 11, 2024
@develop7
fix: unix -> unix-compat, minus getpwuid ref
deb41df 
Works around compilation failure on Windows caused by the
lack of getpwuid function in there.

iand675#109
@develop7 develop7 mentioned this issue Apr 15, 2024
Merged
develop7 added a commit to develop7/hs-opentelemetry that referenced this issue May 30, 2024
@develop7
fix: unix -> unix-compat, minus getpwuid ref
ab36cdd 
Works around compilation failure on Windows caused by the
lack of getpwuid function in there.

iand675#109
@develop7
Copy link
Contributor Author

develop7 commented Nov 4, 2024

Now that the #114 is merged, and until the Windows CI is ready and proves this otherwise (or anyone else would), I deem this issue resolved.

@develop7 develop7 closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@develop7