Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access-token #38

Closed
agbeltran opened this issue Jul 7, 2021 · 3 comments
Closed

Fix access-token #38

agbeltran opened this issue Jul 7, 2021 · 3 comments

Comments

@agbeltran
Copy link
Member

the GA is failing for PRs (see #37 and #28) and we need to investigate and provide an access-token

@louise-davies
Copy link
Contributor

I think this is due to those PRs coming in from forks, which means they don't have access to the encrypted secret (see https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow). However, we only need the access token for publishing, which only happens once merged (and thus will definitely have the access token) so there should be a way to fix this issue for builds only

@louise-davies
Copy link
Contributor

See enriikke/gatsby-gh-pages-action#27
aka we should either use the solution in that thread or switch to the main github pages action

@agbeltran
Copy link
Member Author

thanks @louise-davies - this is now fixed 182232e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants