Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI overwrite downloaded dumps if more slots share the same UID #118

Closed
BreakSecurity opened this issue Nov 12, 2019 · 6 comments
Closed

Comments

@BreakSecurity
Copy link

Describe the bug
GUI overwrite downloaded dumps if more slots share the same UID. E.g. if I upload the UID xxx to slot 1, yyy to slot 2, and xxx to slot 3 when I download all the dumps I will obtain only two files instead of three files (xxx is overwritten, even if different manipulation were done by the reader to the two slots)

To Reproduce
Steps to reproduce the behavior:

  1. Upload the same dump to two different slots
  2. Perform different action on the slots
  3. Click on 'Select All'
  4. Click on 'Download Dump'
  5. Select a folder
  6. See error (we lost one of the two dump)

Expected behavior
A suffix should be added to the UID. E.g. xxx_slot_n (where UID = xxx and n is the slot number)

Desktop (please complete the following information):

  • OS: Windows 10
@iceman1001
Copy link
Owner

Hm, never thought of having the same dump on multiple slots. I agree it has a definite value to work like that. The file saving should atleast a _(n) suffix to the filename where n is last existing number plus one.

The idea with slot number also works but gets a bit confusing after awhile. I rather not see GUI usage reflect on filenames. Ie, use on slot 1 or slot N,

@iceman1001
Copy link
Owner

@BreakSecurity You can test the fix. I will close this one.

@BreakSecurity

This comment has been minimized.

@iceman1001
Copy link
Owner

this issue is about downloading dumps.

@BreakSecurity
Copy link
Author

Sorry I commented the wrong issue.

Regarding this one it works pretty good, but to be perfect it should ask the user the desidered output folder and the format (at the moment they are saved in batch to the program folder in .bin format)

@iceman1001
Copy link
Owner

Sounds fair and intersting features. Feel free to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants