-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't allow "reload" from context menu in WebKitView #38
Comments
What if we get rid of webkitview's context menu and use a popover with custom menu items such as "copy", "share", etc.. similarly to what bijiben does: cc @allanday |
Looks very cool ;) Hope there widget for this ;) |
We've had some problems with those floating popovers in bijiben - it's currently difficult to position them correctly with WebKit (see https://bugzilla.gnome.org/show_bug.cgi?id=728859 for some of the details). I agree that the context menu with back, forward, stop and reload isn't needed - it would be great to remove it. For copying selected text, the context menu with only the copy action seems fine in my opinion. |
Note, we have no plans to change anything in WebKit, since as far as I can tell, there is no bug in WebKit. If you start doing those floating popovers in other apps, then I suspect support would be welcome in WebKit if someone contributes it. (But note that Bijiben would not benefit from that work, since it is stuck on an obsolete/unsupported version of WebKit.) Anyway, regarding the reload context menu item. Removing extra context menu items is really easy. The problem is that we're going to be left with only one item in the context menu, and that's going to look bad. I think completely suppressing WebKit's context menu is the way to go; then we can show a popover with just the Copy button or something. |
Hey Michael, that's what I thought. Would you like to implement this small
|
Reference: #38 Signed-off-by: Igor Gnatenko <[email protected]>
I will do this when will wake up ;) |
The text was updated successfully, but these errors were encountered: