Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow "reload" from context menu in WebKitView #38

Open
ignatenkobrain opened this issue Jul 23, 2015 · 7 comments
Open

don't allow "reload" from context menu in WebKitView #38

ignatenkobrain opened this issue Jul 23, 2015 · 7 comments
Assignees
Milestone

Comments

@ignatenkobrain
Copy link
Owner

  1. It has no effect (html loaded from tracker)
  2. it doesn't work ;)
@ignatenkobrain ignatenkobrain added this to the 3.18 milestone Jul 23, 2015
@felipeborges
Copy link
Collaborator

What if we get rid of webkitview's context menu and use a popover with custom menu items such as "copy", "share", etc.. similarly to what bijiben does:
image

cc @allanday

@ignatenkobrain
Copy link
Owner Author

Looks very cool ;) Hope there widget for this ;)

@allanday
Copy link
Collaborator

We've had some problems with those floating popovers in bijiben - it's currently difficult to position them correctly with WebKit (see https://bugzilla.gnome.org/show_bug.cgi?id=728859 for some of the details).

I agree that the context menu with back, forward, stop and reload isn't needed - it would be great to remove it. For copying selected text, the context menu with only the copy action seems fine in my opinion.

@felipeborges felipeborges self-assigned this Jul 23, 2015
@mcatanzaro
Copy link
Collaborator

Note, we have no plans to change anything in WebKit, since as far as I can tell, there is no bug in WebKit. If you start doing those floating popovers in other apps, then I suspect support would be welcome in WebKit if someone contributes it. (But note that Bijiben would not benefit from that work, since it is stuck on an obsolete/unsupported version of WebKit.)

Anyway, regarding the reload context menu item. Removing extra context menu items is really easy. The problem is that we're going to be left with only one item in the context menu, and that's going to look bad. I think completely suppressing WebKit's context menu is the way to go; then we can show a popover with just the Copy button or something.

@mcatanzaro
Copy link
Collaborator

@felipeborges
Copy link
Collaborator

Hey Michael, that's what I thought. Would you like to implement this small
feature yourself? I'll be away for a couple of days.
Em 26/07/2015 18:35, "Michael Catanzaro" [email protected]
escreveu:

See:
https://lazka.github.io/pgi-docs/WebKit2-4.0/classes/WebView.html#WebKit2.WebView.signals.context_menu


Reply to this email directly or view it on GitHub
#38 (comment)
.

ignatenkobrain added a commit that referenced this issue Jul 26, 2015
Reference: #38
Signed-off-by: Igor Gnatenko <[email protected]>
@ignatenkobrain
Copy link
Owner Author

I will do this when will wake up ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants