Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security indicator #75

Open
mcatanzaro opened this issue Jul 26, 2015 · 5 comments
Open

Add security indicator #75

mcatanzaro opened this issue Jul 26, 2015 · 5 comments

Comments

@mcatanzaro
Copy link
Collaborator

If you're going to allow HTTP feeds (you probably have to) then you also need a security indicator. Copying Epiphany's would make sense.

It's also needed for the GNOME Shell portal helper, so maybe it's time to make it into a submodule....

@ignatenkobrain
Copy link
Owner

one thing. we're displaying pages from local cache (it's cached when tracker fetched item).

@mcatanzaro
Copy link
Collaborator Author

WebKit has a page cache too! The correct behavior IMO is to save the security state of the item before adding it to the cache, and load it straight from the cache. (WebKit does that wrong currently.)

See also my patches for Epiphany's security indicator which I really need to land....

@felipeborges
Copy link
Collaborator

@ignatenkobrain @mcatanzaro tracker-miner-rss does the feed fetching, so I don't think there's something effective we can do upstream on News in order to ensure safety in any way.

@mcatanzaro
Copy link
Collaborator Author

Surely we can add a bit in tracker-miner-rss to indicate whether the feed was secure or not. :)

@felipeborges
Copy link
Collaborator

sure, but that would mean that the user would already been exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants