feat: Split sample_bipartite() into two functions for the G(n, m) and G(n, p) case
#1627
Conversation
Current Aviator status
This PR is currently in state
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
| expect_equal(ecount(g5), 8) | ||
| expect_true(bipartite_mapping(g5)$res) | ||
| expect_true(is_directed(g5)) | ||
| expect_output(print_all(g5), "5->11 7->11 8->11 8->12 4->13 5->13 6->13 9->13") |
There was a problem hiding this comment.
this was updated as the seed is now set in a different position.
| expect_equal(ecount(g6), 8) | ||
| expect_true(bipartite_mapping(g6)$res) | ||
| expect_true(is_directed(g6)) | ||
| expect_output(print_all(g6), "11-> 4 11-> 5 12-> 7 12-> 8 12-> 9 14-> 6 14->10 15-> 4") |
There was a problem hiding this comment.
this was updated as the seed is now set in a different position.
|
Locally, an unrelated test (at least, I was assuming it was unrelated 😅 ) is failing. |
…d G(n,p) case docs: fix manual page docs: fix for pkgdown index chore: also deprecate `bipartite()` fix: fix deprecation message docs: run `document()` test: update snap docs: fix manual page for `bipartite_gnp()`
test: fold `sample_bipartite()` tests into `test-games` test: fold `test-hsbm` into `test-games` test: fold `test-chung_lu` into `test-games`
|
Do we want to autogen |
Let's discuss with @krlmlr. I am not skilled at autogen yet. 😅 |
|
@Antonov548: Can you please help autogenerate |
krlmlr
changed the title
sample_bipartite() into two functions for the G(n,m) an…sample_bipartite() into two functions for the G(n, m) and G(n, p) case
Added both functions 👍 |
|
@Antonov548 could you please port |
|
will start a new PR. |
Sure, I can check how it can be moved to autogeneration. |
…d G(n,p) case
Fix #630