Minor changes to OG descriptions

[Mr-Bajs]

The descriptions of the buildings in the OG doesn't come with a uniform standard. Sometimes an increase is spelled numericaly and sometimes by words and sometimes a + or a - sign is added.

Coliseum, Rainbow and Tavern for example spells it out by words.

OG Coliseum

OG Rainbow

OG Tavern

But other building spells it by numbers. Both Storm and Castle adds a + and a - sign but the well does not.

OG Storm

OG Castle

OG Well

It would be nice if it would be more uniform. Example comparison of the Coliseum.

I think v.2 looks the best even if the + and - signs are redundant in some way, but its used in the Storm and Castle in the OG. If it would be changed then it should be applied to artifacts as well, there having a + or - before the number makes it more clear if new artifacts where to be added that have negative or both positive and negative effects.

Mockup example:

Or just leave it as is.
Related PR: #6909

[LeHerosInconnu]

Hello @Mr-Bajs,

I would rather go for version 2, with the sign and the number (example: "+2" and "-2"), and I think the sentences should be reworded so that it is not redundant.

For example:
"gives +2 attack"
Instead of:
"adds +2 attack"

[LeHerosInconnu]

Hello @Branikolog,

Hi, @LeHerosInconnu !
"Increases" is used in many other descriptions, so I'm not strictly against of this word. I'm OK with most variants containing numeric description of the bonus, but I would like to see the number and the attribute itself as close to each other, as it possible (within a single sentence). And I personally like descriptions without "+" more, except castle towers descriptions (where "+5 bonus" looks quite relevant with the word "bonus"). I agree, that "+x something" is a little more informative, but stylistically I think text without "+" and "-" marks looks more pleasant to eye.

It's not so much the word, but its use with the "+" sign.
"Increases" it's already "to add", so the "+" sign is redundant.
With "gives" it works better, because it can be "give more" or "give less".
"Grants" is even better, because for "gives", as a gift, it's always a give and not take action.

For players who don't read the texts too much, or who don't understand the language too much, "+2 spell power" is better (as you also wrote, "more informative", and I would also add "quickly").
All the information is grouped together in one place, preferably at the end of the sentence.
For the aesthetic side, I think it's okay, because the information given is clearer that way.

Also "+" and "-" signs with numbers are commonly used in the interface:
In fheroes2:

[Branikolog]

@LeHerosInconnu
In the example above I consider "+" as a short form of "add" in short calculation list. We also have not so much free space here. So it's OK to have "+" here.
I personally like the form without "+" mark within full literary description of an artifact or a town structure.

It's not so much the word, but its use with the "+" sign.
"Increases" it's already "to add", so the "+" sign is redundant.
With "gives" it works better, because it can be "give more" or "give less".
"Grants" is even better, because for "gives", as a gift, it's always a give and not take action.

I agree, that both "+" and "Increase" cannot be used together.
I personally find "increase" more pleasant to eye and it's also easier to propose inverse definition for "-something" effect. I mean pairs increase/decrease or increase/reduce looks more uniform semantically.

[Mr-Bajs]

I agree, that both "+" and "Increase" cannot be used together. I personally find "increase" more pleasant to eye and it's also easier to propose inverse definition for "-something" effect. I mean pairs increase/decrease or increase/reduce looks more uniform semantically.

Sure without - and + looks better but with - and + is more informative at a quick glance.
And increase is used by default in most cases in OG and fheroes2, in grant is used instead then all instances of the use of increases should be changed to grant for the sake of looking uniform.

You/The Hero
Another thing i noticed, of this is of course a minor or no issue, and only noticed when doing translation but i'll bring it up anyway. The game sometimes refers to you the player and sometimes to the hero.

Seconday Skills refer as the skills belong to the hero, but Primary Skills refers to you (the player). In it context I assume everyone understands what the skills and that the Primary Skills belongs to the hero rather then You. But still it's a little weird.

Example Mysticism

Example Defense Skill

The Primary Skills (and its related descritopns such as Skills Points) descriptions should might be changed into something like so it refers to that the skills belongs to the Hero and not the Player.

Example suggestion:
The Hero's defense skill is a bonus added to each creature's defense skill.
rather than
Your defense skill is a bonus added to each creature's defense skill.

Course the when you have a hero selected you are the hero. So there isn't really an issue. But maybe rules should be implemented going forward when new assets are being added.

Artifacts
Arifacts desc and the events that happen when the hero picks up an artifact refers to you. That is might be inconsistent but i think that works fine though. The short stories that are tied when picking an artifact are better told through a seconday perspective, with You rather then The Hero.

[Branikolog]

Hi, @Mr-Bajs

Sure without - and + looks better but with - and + is more informative at a quick glance.

Both have pros and cons. That's why we're here discussing it. :) The result will be based on all opinions.

Another thing i noticed, of this is of course a minor or no issue, and only noticed when doing translation but i'll bring it up anyway. The game sometimes refers to you the player and sometimes to the hero.

Oh. I find this suggestion nice. Indeed, all skills and attributes are referred to a particular hero (you, as a player, could have several heroes, so each of them has his own set of attributes).

Seconday Skills refer as the skills belong to the hero, but Primary Skills refers to you (the player).

I think it would be nice to have these descriptions referred to a hero, not a player, to keep texts more consistent in this aspect.

[zenseii]

Hi all. Personally I see no problem with having variation, so sometimes "increase", "add" and "grant". This doesn't really have to be the same all over the game. The real issue imo is whether to write the unnecessary "+" or not. I think we can remove it.

[Mr-Bajs]

Sure variation isn't bad either.

I suggest a change into this

Tavern
The Tavern increases morale for troops defending the castle by 1.

The Coliseum
The Coliseum provides inspiring spectacles to defending troops, raising their morale by 2 during combat.

The Rainbow
The Rainbow increases the luck of the defending units by 2.

The Storm
The Storm increases the spell power of defending spell caster by 2.

Also the Statue should be changed from your income into the towns income. Makes its clear that the statues income is tied to the town and not the player.

The Statue
From this
The Statue increases your town's income by %{count} gold per day.
to this
The Statue increases the town's income by %{count} gold per day.

[Branikolog]

Everything seems good to me from the proposal above. 👍
I'm only concerning about the in rainbow description:

The Rainbow
The Rainbow increases the luck of the defending units by 2.

Since all other descriptions don't have the before units.

[Mr-Bajs]

Primary Skills into something like this, I suggest the second option, that makes its more clear that it isn't global effects.

Attack Skill

1. The hero's attack skill is a bonus added to each creature's attack skill.
2. The hero's attack skill is a bonus added to each of the hero's creatures' attack skill.

Defense Skill

1. The hero's defense skill is a bonus added to each creature's defense skill.
2. The hero's defense skill is a bonus added to each of the hero's creatures' defense skill.

Spell Power

1. The hero's spell power determines the length or power of a spell.
2. The hero's spell power determines the duration or power of the hero's spells.

Knowledge

1. The hero's knowledge determines how many spell points your hero may have. Under normal circumstances, a hero is limited to 10 spell points per level of knowledge.
2. The hero's knowledge determines how many spell points the hero may have. Under normal circumstances, a hero is limited to 10 spell points per level of knowledge.

[zenseii]

Sounds good to me. Just note that it should be each of the hero's creatures' and not creature's.

I would also suggest to change to duration rather than length for the spell power description, but this isn't critical.

[Mr-Bajs]

Okey. Sure, duration is better.

[Branikolog]

I personally prefer shorter variants for each description (1, 1, 1, 2).

[zenseii]

@Mr-Bajs

I would also suggest to change to duration rather than length for the spell power description, but this isn't critical.

And now I see that I'm arguing against myself 🤣

[Mr-Bajs]

Secondary skills are mostly fine. But might be changed from your hero's into the hero's but it's fine as it is. But if multiplayer is improved then you might wanna view your ally hero, then it make more sense if its 'the hero' and not 'your hero'. But change is probably unnecessary.

A few secondary skills should be changed to make it clear that the skill is tied to the hero and not the player.

Diplomacy
OG: Diplomacy allows you to negotiate with monsters who are weaker than your group.
Suggestion: Diplomacy allows the hero to negotiate with monsters that are weaker than the hero's army.

Eagle Eye refers to the hero as 'him' which is wierd if the hero is a female such as a witch. Should be neutral.

Eagle Eye
OG: Eagle Eye gives your hero a %{count} percent chance to learn any given 1st or 2nd level enemy spell used against him in a combat.
Suggestion: Eagle Eeye gives the hero a %{count} percent chance to learn any given 1st or 2nd level enemy spell used against the hero in a combat.

Pathfinding
OG: Pathfinding reduces the movement penalty for rough terrain by %{count} percent.
Suggestion: Pathfinding reduces the hero's movement penalty for rough terrain by %{count} percent.

Archery
OG: Archery ncreases the damage done by range attacking creatures by %{count} percent.
Suggestion: Archery increases the damage done by the hero's range attacking creatures by %{count} percent.

[LeHerosInconnu]

Hello everyone,

Okay, let's go with "verb" and "by X" for the description.
It will always be possible to add a quick info in brackets for example like in the original game (to be improved because not all artifacts have this quick info in the original game).

In original game:

"You/The Hero"
Yes, it is better to refer to the hero.

All the changes concerning the buildings, secondary skills and primary skills seem to be appropriate.