Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: password in memory #7

Open
c0d3z3r0 opened this issue Feb 6, 2018 · 2 comments
Open

security: password in memory #7

c0d3z3r0 opened this issue Feb 6, 2018 · 2 comments

Comments

@c0d3z3r0
Copy link
Contributor

c0d3z3r0 commented Feb 6, 2018

password
Must contain the BIOS supervisor password (aka 'pap'), if set, to be able to do any change.

Every subsequent password change will be authorized with this password. The password may be unloaded by writing an empty string. Writing an invalid password may trigger the BIOS' invalid password limit, such that a reboot will be required in order to make any further BIOS changes.

From security perspective leaving the password in memory is not a good idea.
IMHO every write should contain the password / auth string.

Any other opinions?

@iksaif
Copy link
Owner

iksaif commented Feb 6, 2018

Makes sense, but this is going to make the current debugfs interface quite hard to use. If there was another interface (char device?) then clearly that would be the way to go.

@c0d3z3r0
Copy link
Contributor Author

c0d3z3r0 commented Feb 6, 2018

Ah, I'm sorry. I assumed having a char device... #7 depends on #8
Not sure if the debugfs interface should be kept at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants