Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact solution mismatch should print a loud warning message #166

Open
inducer opened this issue Dec 3, 2020 · 3 comments
Open

Exact solution mismatch should print a loud warning message #166

inducer opened this issue Dec 3, 2020 · 3 comments

Comments

@inducer
Copy link
Contributor

inducer commented Dec 3, 2020

Currently (b2c9a41), at least in vortex-mpi, it just swallows the exception. Possibly, this message could be printed by advance_state, to assure that something shows up.

@MTCam
Copy link
Member

MTCam commented Dec 3, 2020

I think I liked my previous solution which failed on all ranks simultaneously, and printed a solution mismatch message. Regardless, it was replaced by this exception at some point - which has the problem you note, and can also cause the simulation to hang when some ranks exit and some don't.

Can we not just print the message when the exception is caught?

@inducer
Copy link
Contributor Author

inducer commented Dec 3, 2020

Can we not just print the message when the exception is caught?

We can't count on driver maintainers to get this right IMO.

can also cause the simulation to hang when some ranks exit and some don't.

No, cf. #115. (cc @matthiasdiener)

@MTCam
Copy link
Member

MTCam commented Dec 4, 2020

Can we not just print the message when the exception is caught?

We can't count on driver maintainers to get this right IMO.

can also cause the simulation to hang when some ranks exit and some don't.

No, cf. #115. (cc @matthiasdiener)

Totally agree. I did not realize the lone exit issue was fixed by #115. Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants