Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOS + Units #76

Open
inducer opened this issue Aug 24, 2020 · 1 comment
Open

EOS + Units #76

inducer opened this issue Aug 24, 2020 · 1 comment

Comments

@inducer
Copy link
Contributor

inducer commented Aug 24, 2020

Continue the discussion from https://github.com/illinois-ceesd/mirgecom/pull/7/files#r468194445.

Currently, the EOS and the Euler RHS do not document in what units inputs are assumed to be and in what units results are returned. I don't expect this to be a sustainable situation.

cc @MTCam @anderson2981 @lukeolson @jbfreund
@MTCam
Copy link
Member

MTCam commented Aug 25, 2020 •
edited
Loading

The only dimensional parameter in the Euler module is documented here.

@inducer inducer mentioned this issue Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inducer @MTCam