Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass-throughs in multiphysics coupled operator can change expected/default behaviors #896

Open
MTCam opened this issue May 3, 2023 · 2 comments

Comments

@MTCam
Copy link
Member

MTCam commented May 3, 2023

We papered over this issue in #894 , but it remains to find a robust solution for defaulting parameters in a way that doesn't override or change the expected behavior. Read #894 for a better description of the issue.

@majosm
Copy link
Collaborator

majosm commented May 3, 2023

Another possibility would be to remove the flux functions from the interface of coupled_ns_heat_operator altogether, and pass them in through the ns_operator= argument you added in #877:

my_ns_operator = partial(
    ns_operator,
    inviscid_numerical_flux_func=...,
    viscous_numerical_flux_func=...)

rhs = coupled_ns_heat_operator(..., ns_operator=my_ns_operator)

@MTCam
Copy link
Member Author

MTCam commented May 3, 2023

Another possibility would be to remove the flux functions from the interface of coupled_ns_heat_operator altogether, and pass them in through the ns_operator= argument you added in #877:

I like this a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants