Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-11: updated logic to call listeners on empty name resolution and added a corresponding docker build container #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gh-11: updated logic to call listeners on empty name resolution and added a corresponding docker build container #12

wants to merge 1 commit into from

Conversation

mjpitz
Copy link
Collaborator

@mjpitz mjpitz commented Aug 22, 2019 •
edited
Loading

Resolves gh-11

@mjpitz mjpitz requested a review from wegrata August 22, 2019 17:26
@mjpitz mjpitz changed the title gh-7: updated logic to call listeners on empty name resolution and added a corresponding docker build container gh-11: updated logic to call listeners on empty name resolution and added a corresponding docker build container Aug 22, 2019
@mjpitz
Copy link
Collaborator Author

mjpitz commented Aug 22, 2019

Woops, I tagged the wrong issue in my commit. I'll squash and rewrite the commit message on approval.

@mjpitz mjpitz requested review from junpengl and removed request for wegrata August 22, 2019 18:02
@TaichiHo
Copy link

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpengl junpengl Awaiting requested review from junpengl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty Consul services list causing program to hang in ConsulNameResolver
2 participants
@mjpitz @TaichiHo