Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying s3ForcePathStyle for s3 provider. #1000

Open
lazaroofarrill-opstalent opened this issue Jun 18, 2024 · 4 comments
Open

Allow specifying s3ForcePathStyle for s3 provider. #1000

lazaroofarrill-opstalent opened this issue Jun 18, 2024 · 4 comments

Comments

@lazaroofarrill-opstalent
Copy link

lazaroofarrill-opstalent commented Jun 18, 2024

Is your feature request related to a problem? Please describe.
I want to use Minio locally instead of S3 to speedup the render tests. With the version of the AWS SDK used the endpoint behavior is buggy when URL resolution is in virtual host mode. The easiest way to avoid this is forcing path.

This is the error I get when s3 using virtual host style with local Minio instance.

UnknownEndpoint: Inaccessible host: `remake-staging-prod-result-mno1f0aw.localhost' at port `undefined'.

Describe the solution you'd like
Allow setting the s3 path style either via a parameter or an environment variable when using a custom endpoint.

Describe alternatives you've considered
Allow passing a custom s3 clients to the render job. This might be more flexible when building of top of nexrender core like I am but it would not be portable to users of the server or the cli.

Additional context
This is is what I did to my local dependency to get Minio working locally.
image

@inlife
Copy link
Owner

inlife commented Jul 5, 2024

That sounds reasonable, I think the path style can be a good addition.

@lazaroofarrill-opstalent
Copy link
Author

Would you like me to make a PR?

@inlife
Copy link
Owner

inlife commented Jul 10, 2024

I would love it if you did!

Copy link

stale bot commented Sep 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants