Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format check to CI #41

Open
RobotSail opened this issue May 15, 2024 · 2 comments
Open

Add format check to CI #41

RobotSail opened this issue May 15, 2024 · 2 comments

Comments

@RobotSail
Copy link
Member

We want to add yarn format:check as a step in the CI. We have added this command in PR #39, but ran into problems when enabling this check, where the local next.config.js passed the linter errors, but failed for some reason in CI.

@Gregory-Pereira
Copy link

/assign

@Gregory-Pereira
Copy link

With Tmate ssh I was able to determine that this comes from the Setup Pages step, where basePath is injected into the next.config.js which breaks the formatting. After discussing with @RobotSail, we decided to remove the base path injection and parameterize it or set it in ENV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants