Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to delete/expire a stale editgroup #76

Open
eblanton opened this issue Apr 13, 2021 · 1 comment
Open

There is no way to delete/expire a stale editgroup #76

eblanton opened this issue Apr 13, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request schema Requires change of API/entity schema

Comments

@eblanton
Copy link

If an editgoup is superseded (for example, I created https://fatcat.wiki/editgroup/szfubtxhwrgzboa2yxaqjy2fmq as two editgroups, then merged them when I figured out how to do that, leaving the other editgroup stranded), there is no apparent way to delete or expire the superseded editgroup from the user's web interface. It shows as an open editgroup indefinitely.

A workaround is to remove all changes from the editgroup and then re-use it for the next submission.

@bnewbold bnewbold self-assigned this Apr 13, 2021
@bnewbold bnewbold added enhancement New feature or request schema Requires change of API/entity schema labels Apr 13, 2021
@bnewbold
Copy link
Contributor

This is one of the top-priority handful of user experience problems.

I can't remember if there is a verification check to prevent this, but you could also try submitting an empty editgroup (with no edits) and I can merge it, just to get it out of you stack.

I think the fix is to add a is_deleted flag to editgroups, and if that flag is set suppress displaying it in almost all situations. This will require a small SQL schema change, migration, and API schema update. Unfortunately this means it probably won't get fixed in the next month or two. If there are other editgroup workflow improvements, it would be good to tackle them all together. For example, it would also be nice to be good to update work-in-progress edits with a single atomic API call (single database transaction); currently the web interface does updates as delete-then-insert, which can lose state if there is a problem with the second API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schema Requires change of API/entity schema
Projects
None yet
Development

No branches or pull requests

2 participants