Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-edit results in error 400 #92

Open
NeoTheThird opened this issue Feb 10, 2022 · 3 comments
Open

re-edit results in error 400 #92

NeoTheThird opened this issue Feb 10, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@NeoTheThird
Copy link
Contributor

if i try to re-edit on editgroup_y4i2is56inghdng7fzkptaqop4, i get the following error when clicking save:

image

@bnewbold bnewbold added the bug Something isn't working label Feb 10, 2022
@bnewbold bnewbold self-assigned this Feb 10, 2022
@NeoTheThird
Copy link
Contributor Author

Issue still present, just had the same thing happen on https://fatcat.wiki/editgroup/rrxqtibgqzfk7chzcifixu63x4. Also noticed that the previously made edits aren't visible when clicking re-edit. Let me know if you want me to open a new issue for that.

@bnewbold
Copy link
Contributor

Yes, please open a second issue!

@bnewbold
Copy link
Contributor

I'm having trouble reproducing this specific 400 error via re-editing. I have found a couple small issues, but I don't think they are related to the above. The above error would happen if an entity was updated with the revision field set to a specific value, which I could see happening if updating a work entity via TOML (which I will fix), but i'm not sure what other behavior is triggering it.

I assume that the editgroup was back in "edit" mode (the current state), and that you followed the green "[re-edit]" link. Which entity did you try to update, the release or the work? And did you use the form, or TOML editing?

Also, you noted in a comment:

also, my edit history has gotten a little weird, not sure if what we did here confused fatcat: https://fatcat.wiki/editor/vugi5uheq5fardhcqr3eynznga/editgroups

Which part of the edit history is unexpected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants