Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn.lock across the project to .gitignore #524

Open
elit-altum opened this issue Mar 14, 2021 · 4 comments
Open

Add yarn.lock across the project to .gitignore #524

elit-altum opened this issue Mar 14, 2021 · 4 comments
Labels
Discussion A topic for community discussion

Comments

@elit-altum
Copy link

What is the context for this discussion?

While making any changes to the codebase yarn.lock in multiple sub-directories is changed while setting up the project. Which in turn will come up as a commit in a PR and pollute it.

Elaborate on the discussion topic.

Looking at the scenario I can suggest the following options:

  1. Add all lock files to gitignore so they are not tracked by git in the future.
  2. Enforce all future installations of the codebase to use the same lock file by suggesting devs to use yarn install --frozen-lockfile instead of yarn install for the future setups. [ reference ]

Stakeholders

I think all devs making their contribution for the first time will face this issue.

@elit-altum elit-altum added the Discussion A topic for community discussion label Mar 14, 2021
@Swapnil-2001
Copy link

@elit-altum can I make a PR adding lock files to gitignore?

@elit-altum
Copy link
Author

@Swapnil-2001 I have opened this thread for discussion here, I already have a PR ready for this!

@Swapnil-2001
Copy link

Oh okay okay.

@jbuckner
Copy link
Contributor

What is the issue that's happening here? Are you seeing the yarn.lock file change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion A topic for community discussion
Projects
None yet
Development

No branches or pull requests

3 participants