Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Server Source Control' and 'Server Command Menu' flipped after connecting to different server #1458

Open
mbries opened this issue Nov 13, 2024 · 11 comments

Comments

@mbries
Copy link

mbries commented Nov 13, 2024

Working in a client environment with many remote HealthShare instances, I experienced twice in a single day that after switching to a new server, clicking on 'Server Source Control' would actually execute 'Server Command Menu' and vice versa.

Clicking this 'Server Source Control':
image
Results in this prompt:
image

The HealthShare instances were all 2021.1, and the InterSystems Server Manager version was v3.8.0. The only remedy I have found for this issue is to restart VSCode entirely. Forcing a reconnect to the server in question does not solve the problem.

@isc-bsaviano isc-bsaviano transferred this issue from intersystems-community/intersystems-servermanager Nov 13, 2024
@isc-bsaviano
Copy link
Contributor

@mbries The Server Actions menu is contributed by the vscode-objectscript extension, so I moved this issue there. What exactly are you doing when you're "switching to a new server"?

@mbries
Copy link
Author

mbries commented Nov 13, 2024

Initially I'll have a single remote server added as a folder in a VSCode workspace - DEVUCR for example. VSCode is actively connected to the first server and both selections are working as expected. I then add another remote server - say DEVCV, to my VSCode Workspace. I open a code artifact from the 2nd server, and verify that the active connection is indeed the correct server (DEVCV shows in the connection box in the bottom left corner). Then no matter which way I access either Server Source Control or Server Command Menu I get the flipped behavior: Right clicking on the open document or clicking on the active connection box and choosing it from the center dropdown menu doesn't make any difference.

Edit to add: InterSystems ObjectScript extension is version v2.12.10

@isc-bsaviano
Copy link
Contributor

Thanks for the detailed response. That sounds really strange. I will try to reproduce it.

@isc-bsaviano
Copy link
Contributor

@mbries I wasn't able to reproduce this issue. Here's what I tried:

  • Opened a workspace folder that contains two isfs folders connected to the same server.
  • Opened a document in one folder and verified that the source control and server command menus were correct.
  • Added a third isfs folder using the Add Server Namespace to Workspace... command that is connected to a different server.
  • Opened a document in the new folder and verified that the source control and server command menus were correct.

@isc-bsaviano
Copy link
Contributor

isc-bsaviano commented Nov 14, 2024

I think the confusion is caused the the dropdown's prompt message. It always says "Pick server-side command to perform..." even if you selected the source control menu.

@isc-bsaviano
Copy link
Contributor

@mbries Can you confirm that the correct menu options are appearing, even if the prompt is confusing?

@mbries
Copy link
Author

mbries commented Nov 15, 2024

@isc-bsaviano when this occurs the correct menu options are not appearing. 'Server Source Control' prompts for a server command, while 'Server Command Menu' prompts for the source control options.

I was doing this exact workflow today and the issue did not re-occur, I will continue to monitor for it so I can determine if there are more contributing factors.

@isc-bsaviano
Copy link
Contributor

Thanks for clarifying @mbries. Is it possible that this is a server issue? I looked at our code in this area and I don't see any places where the menus could get mixed up.

@isc-bsaviano
Copy link
Contributor

Hi @mbries, are you still experiencing this issue? Have you been able to identify if happens with more than one server?

@mbries
Copy link
Author

mbries commented Dec 3, 2024

@isc-bsaviano Hi Brett: yes this is still occurring. It seems to happen more prevalently (or possibly exclusively?) with remote instances that are co-located on the same server / VM. For example, we have 3 HealthShare instances running in our DEV and TEST clusters (CV, UCR, and ESB). Adding a UCR namespace, then a ESB namespace to a Workspace from the same server seems to trigger it, but it's inconsistent. Several of my colleagues have encountered this as well.

Edit to add: the instances this is occurring on are now all on HS 2024.1. It has occurred both before and after the upgrade from 2021.2

@isc-bsaviano
Copy link
Contributor

Thanks for the update @mbries. This is a really interesting issue. I think the next step would be to get a network trace (using wireshark or the Web Gateway's HTTP Trace tool) so we can see exactly what the request and response are. This will help me identify if this is a VS Code issue (it's asking for the wrong menu) or a server issue (the server is responsing with the wrong items).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants