Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails in non-English Windows. #12

Open
msokolowskihbz opened this issue Sep 29, 2022 · 3 comments
Open

Installation fails in non-English Windows. #12

msokolowskihbz opened this issue Sep 29, 2022 · 3 comments

Comments

@msokolowskihbz
Copy link

msokolowskihbz commented Sep 29, 2022

Problem:
When "dotnet" command outputs in local language

Trwa określanie projektów do przywrócenia...
Przywrócono element C:\1\console.msbuildproj (w 725 ms).

It's not properly detected by install script and gives error.

Solution:
According to this posts: Switch CLI to a non-system language #8686, How to change display language to English? #821.
One should set environment variable "DOTNET_CLI_UI_LANGUAGE=en".

I did it globally but IMHO it should be done during installation.

@jakubmisek
Copy link
Contributor

thanks @msokolowskihbz - I'll look into it

@jakubmisek
Copy link
Contributor

does it cause some issues? I don't see why it should be in english

@msokolowskihbz
Copy link
Author

Absolutly. Because in extension.ts line 210

Extension detects succes by string comparision and "Przywrócono element" do not match "Restore completed in"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants