Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Gutenslider plugin for Wordpress #99

Open
marinasundstrom opened this issue Mar 25, 2021 · 10 comments
Open

[Feature] Gutenslider plugin for Wordpress #99

marinasundstrom opened this issue Mar 25, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@marinasundstrom
Copy link

Description
Gutenslider Wordpress plugin does not have a NuGet packages.

Issues
I have tried to add and compile the plugin source files manually. Removing unnecessary Debug classes.

The experience in the Gutenberg editor works, but the slider does not render correctly on pages.

Plugin page: https://sv.wordpress.org/plugins/gutenslider/

@marinasundstrom marinasundstrom added the enhancement New feature or request label Mar 25, 2021
@marinasundstrom
Copy link
Author

marinasundstrom commented Apr 1, 2021

@jakubmisek I really would like to know how to make this work.

As I said, the editor experience is working, but the slider itself does not display correctly when viewing page.

@jakubmisek
Copy link
Collaborator

I'm just assuming there is some generated javascript that is messed up :) do you have any javascript errors in the browsers' console?

@marinasundstrom
Copy link
Author

@jakubmisek No, and that is strange. No, errors (or warnings). The images just display after each other on the page.

I have tried another plugin too (Getwid). The markup is rendered but the JavaScript does not run. I wonder why?
Is it related to WP.NET?

I copied the plugin files to the directory and it compiled without problems.

@jakubmisek
Copy link
Collaborator

feels like something in wordpress did not enqueue the .js file to "some" array, so it's not added to the HTML code .. probably easiest would be to compare the output from regular wordpress+php with wpdotnet.

@jakubmisek jakubmisek added bug Something isn't working and removed enhancement New feature or request labels Apr 2, 2021
@jakubmisek
Copy link
Collaborator

I'm experiencing a similar issue with some themes, like it's missing images

@marinasundstrom
Copy link
Author

Other plugins do not work either. It is in the frontend. The editor experience works.

@jakubmisek
Copy link
Collaborator

thanks, I still can't find the cause of it. Do you have any hints, or observations, what's going on? I would suspect something in PHP arrays, maybe reference counting going wrong.

@hez2010
Copy link

hez2010 commented Apr 13, 2021

Same for syntaxhighlight involved: it works in editor but not in the published page, I have to add "brush:language" to custom css (which should be done automatically by the plugin) to make it display correctly.

@jakubmisek
Copy link
Collaborator

@hez2010 so it might be a missing CSS, seems like WordPress internally misses the stylesheet file

@marinasundstrom
Copy link
Author

@jakubmisek I also noticed when I wrote my own plugin that the activation hook did not execute when deactivating and re-activating it. I had to restart the WP app for the hook to execute on re-activation. I assume this is not an expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants