Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] Unused npm-watch dependency #200

Open
miqmago opened this issue Sep 4, 2023 · 6 comments
Open

[project] Unused npm-watch dependency #200

miqmago opened this issue Sep 4, 2023 · 6 comments

Comments

@miqmago
Copy link

miqmago commented Sep 4, 2023

The @trapezedev/project depends on npm-watch but it seems not to be used anywhere.

npm-watch seems not to be regularly mantained. npm-watch depends on nodemon@^2.0.7 (06/01/2021).
Right now nodemon is 3.0.1.

On an npm audit fix it raises a Severity: moderate

Maybe this dependency could be removed if not used anywhere.

@chacabuk
Copy link

chacabuk commented Sep 7, 2023

Depends too on mergexml that seems not to be regularly mantained and depend on deprecated "formidable": "^1.2.1"

@Ericlm
Copy link

Ericlm commented Sep 28, 2023

Just wanted to give support to this issue, as npm-watch is blocking updates of nodemon, and triggers vulnerability warning :)

@Ericlm
Copy link

Ericlm commented Apr 30, 2024

npm-watch received a recent release to address the nodemon dependency.
However, as @trapezedev/project is using npm-watch from 0.9.0 instead of 0.12.0, it continues to trigger audit warnings.
I think the simplest way is to remove the dependency as suggested, or at least upgrade npm-watch to ^0.12.0

@chvonrohr
Copy link

GitLab detects this as high severity risk!

Versions of the package semver before 7.5.2 is vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

I really think you should upgrade or remove that package. If this isn't done after one year (even when receiving PRs, the project seems abandoned, which would be a sad for the whole Ionic community.

To still be compliant we overrule the dependency in the package.json like this:

"overrides": {
    "@trapezedev/configure": {
      "npm-watch": "0.13.0"
    }
}

@AntiGuideAkquinet
Copy link

Seems like this can be closed as de23267 fixed it so version 7.1.0 and up are not vulnerable anymore.

@Yolgie
Copy link

Yolgie commented Nov 26, 2024

this has been fixed when removing npm-watch in ticket #224 and version 7.1.3

https://github.com/ionic-team/trapeze/releases/tag/7.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants