Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Deprecate in favor of npm-go-ipfs #45

Closed
lidel opened this issue Aug 6, 2020 · 7 comments · Fixed by #46
Closed

Deprecate in favor of npm-go-ipfs #45

lidel opened this issue Aug 6, 2020 · 7 comments · Fixed by #46
Labels
need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Contributor

lidel commented Aug 6, 2020

So.. we have two ways of getting go-ipfs via NPM:

Alex fixed a bunch of stuff in ipfs/npm-kubo#26, and stated that [npm-go-ipfs-dep] should be retired.

Should we deprecate go-ipfs-dep and point people at go-ipfs?
Any reason for maintaining both?

cc @olizilla @achingbrain @hugomrdias @aschmahmann @vasco-santos @Gozala @andrew

@lidel lidel added the need/triage Needs initial labeling and prioritization label Aug 6, 2020
@Gozala
Copy link

Gozala commented Aug 7, 2020

I don't see any good reason to keep both, but I also have the least context.

@achingbrain
Copy link
Contributor

The changes I made to the go-ipfs module should make it a drop-in replacement so there's no need for both.

This module should be deprecated with a message saying to use go-ipfs and this repo should be archived/moved to the ipfs-inactive org.

See also: #42

@achingbrain achingbrain linked a pull request Aug 7, 2020 that will close this issue
@achingbrain
Copy link
Contributor

achingbrain commented Aug 7, 2020

I've added a deprecation warning to go-ipfs-dep on npm saying to use go-ipfs instead and #46 will add a big warning to the README.

If everyone's happy we can merge that and move this repo to ipfs-inactive.

@olizilla
Copy link
Contributor

olizilla commented Aug 7, 2020

Now that the go-ipfs dep can do it all, I am very much in favour of deprecating and moving to ipfs-inactive. Nice work @achingbrain

@andrew
Copy link

andrew commented Aug 8, 2020

Quite a few projects have go-ipfs-dep as a dependency, would be good to send them a PR to switch if we're not going to be publishing updates anymore: https://ipfs.ecosystem-dashboard.com/packages/1859?direct=true

@lidel
Copy link
Contributor Author

lidel commented Oct 16, 2020

@andrew has a good point.

At a very minimum, we need:

Then,

I can help with this if

@lidel lidel reopened this Oct 16, 2020
@lidel lidel pinned this issue Oct 16, 2020
@lidel lidel changed the title Deprecate in favor of npm-go-ipfs? Deprecate in favor of npm-go-ipfs May 19, 2021
@lidel
Copy link
Contributor Author

lidel commented May 24, 2021

Deprecated on NPM, will move to https://github.com/ipfs-inactive/ shortly

@lidel lidel closed this as completed May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants