From 1afe2bc8993456702841c1b78dd2e4bf211bdca0 Mon Sep 17 00:00:00 2001 From: Scott Todd Date: Tue, 5 Nov 2024 10:30:41 -0800 Subject: [PATCH] Mark failing Colab notebook tests as XFAIL. (#19031) See https://github.com/iree-org/iree/issues/18919. Tested here: https://github.com/iree-org/iree/actions/runs/11689771962 * I was able to reproduce the `tensorflow_hub_import.ipynb` compile failure in Colab. Might be a real compiler regression in there. * I was _not_ able to reproduce the `tflite_text_classification.ipynb` error - likely some diff between the simulated test environment we have and what is running in hosted Colab instances. --- samples/colab/test_notebooks.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/samples/colab/test_notebooks.py b/samples/colab/test_notebooks.py index 8a17e32e584b..646fc99c0a4e 100755 --- a/samples/colab/test_notebooks.py +++ b/samples/colab/test_notebooks.py @@ -22,7 +22,9 @@ ] NOTEBOOKS_EXPECTED_TO_FAIL = [ - # None! + # See https://github.com/iree-org/iree/issues/18919 + "tensorflow_hub_import.ipynb", + "tflite_text_classification.ipynb", ]