Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change file and rerun points via service #6

Open
andyblarblar opened this issue Apr 10, 2022 · 1 comment
Open

Add ability to change file and rerun points via service #6

andyblarblar opened this issue Apr 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@andyblarblar
Copy link
Member

To further expand this nodes usefullness,I propose the addition of a service interface that allows for changing the filepath of the readable file, and another (or the same?) that performs the waypoint following on command, rather than on IPP publish like now.

This implimentation should be pretty easy, just make one service change the filepath feild, and another call get waypoints followed by publish waypoints. The only thing to keep in mind is cancelling an already running waypoint follow action if the user calls a rerun while a previous run is still ongoing.

@andyblarblar andyblarblar added the enhancement New feature or request label Apr 10, 2022
@girvenavery2022
Copy link
Collaborator

This sounds like a good addition to this package. like you have said, you just have to be careful to not cancel an already running waypoint follow action by asking for a rerun too early. This is something I am going to have to implement on the rviz plugin I am developing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants