Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong lang attribute #156

Open
Wawet76 opened this issue Dec 3, 2019 · 3 comments
Open

Wrong lang attribute #156

Wawet76 opened this issue Dec 3, 2019 · 3 comments

Comments

@Wawet76
Copy link

Wawet76 commented Dec 3, 2019

The lang attribute in the html tag is always set to "en" :

The web site is translated, so this value is wrong when the user is in a non English speaking country.

This attribute should indicate the main language used on the web site, or be removed.

Wawet76 added a commit to Wawet76/web that referenced this issue Dec 3, 2019
@konklone
Copy link
Member

What's the impact of this attribute being wrong for a non-English speaker?

@ghost
Copy link

ghost commented Jan 13, 2020

what's the impact of this?

the impact is purely semantic.

since many sites have this attribute wrong anyways and/or content of the webpage can be in several languages, browsers, parsers and crawlers dont rely on it to be the final truth for language determination.

realistically, not even slight SEO-score difference in comparison to the correct solution,
big OCD-score dive tho.

@Wawet76
Copy link
Author

Wawet76 commented Oct 3, 2023

It's used by some screen readers for accessibility for blind people....
More commonly (but not needed for isitchristmas) : It's used by browsers to choose default spellchecker to use on inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants