-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cml runner seems to try and pull images from a quay.io repo instead of dockerhub #1433
Comments
@AlistairMaccallum I suspect this is coming from some Openshift k8s configuration. After some searching the contents of Regardless, you should be able to resolve this by explicitly setting the image like so: cml runner launch \
--cloud=kubernetes \
--labels=cml-k8s-gpu \
--cloud-image=ghcr.io/iterative/cml:0-dvc3-base1
or your choice of image. |
Thanks @dacbd that's working now, however, is there a way to provide credentials or indicate an existing k8s registry secret to use within the the cluster to pull from a private ecr repo? Just for reference, my
|
@AlistairMaccallum do you mean like this: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ or are you trying to pull another image from your workflow that is running in the cml image? |
@dacbd Yes, I have a k8s registry secret like what is described in the link, I'm trying to run cml like this
I had tried this as part of the job but I suspect it doesn't help because the k8s cluster needs the credential to pull the image rather than the container the action is running in. steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4 # More information on this action can be found below in the 'AWS Credentials' section
with:
aws-region: eu-west-2
- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v2 |
@AlistairMaccallum, thats correct, it would be k8s doing the pulling of the container and not the cml command. I'm sure there are plenty of help articles out there for accessing ECR from your k8s cluster. If you get stuck feel free to reach out again but I'm not sure how much help we can be. |
@dacbd This seems to answer my question #1342 however I think a more intuitive way would be to have an additional flag for the runner something like this maybe? Where you can specify a secret that exists in kubernetes already.
|
Bug Report
runner:
Description
cml runner seems to try and pull images from a quay.io repo instead of https://hub.docker.com/r/iterativeai/cml/tags
Reproduce
cml runner launch
--cloud=kubernetes
--labels=cml-k8s-gpu
Expected
Kubernetes is able to pull the required image for the Job
Environment information
Attempting to run jobs via github arc and kubernetes in an on-premise cluster.
Additional Information (if any):
The text was updated successfully, but these errors were encountered: