Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much diagnostics for quick commands #723

Closed
dmpetrov opened this issue Dec 18, 2024 · 4 comments
Closed

Too much diagnostics for quick commands #723

dmpetrov opened this issue Dec 18, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmpetrov
Copy link
Member

dmpetrov commented Dec 18, 2024

Description

I run a diff for two very small datasets. The output is a bit overwhelming 😅 I'm not sure I need any diagnostic for query that run instantly (few seconds).

We need some smarter way of reporting the progress. Like - report it only if a query take more than let say 5 seconds.

>>> diff.show()
Processed: 1 rows [00:00, 387.29 rows/s]
Generated: 3 rows [00:00, 1252.65 rows/s]
Processed: 1 rows [00:00, 295.87 rows/s]
Generated: 3 rows [00:00, 937.76 rows/s]
Processed: 1 rows [00:00, 418.76 rows/s]
Generated: 3 rows [00:00, 1354.46 rows/s]
Processed: 1 rows [00:00, 370.78 rows/s]
Generated: 3 rows [00:00, 1222.00 rows/s]
Cleanup: 7 tables [00:00, 3716.00 tables/s]
    file file file    file file      file                      file     file score
  source path size version etag is_latest             last_modified location
0     s1   p1    0       1   e1         1 1970-01-01 00:00:00+00:00     None     1
1     s2   p2    0       1   e1         1 1970-01-01 00:00:00+00:00     None     2
2     s3   p3    0       1   e1         1 1970-01-01 00:00:00+00:00     None     3

Here I'd like to see the final result only like:

>>> diff.show()
    file file file    file file      file                      file     file score
  source path size version etag is_latest             last_modified location
0     s1   p1    0       1   e1         1 1970-01-01 00:00:00+00:00     None     1
1     s2   p2    0       1   e1         1 1970-01-01 00:00:00+00:00     None     2
2     s3   p3    0       1   e1         1 1970-01-01 00:00:00+00:00     None     3
@dmpetrov dmpetrov added the enhancement New feature or request label Dec 18, 2024
@dmpetrov
Copy link
Member Author

It's also related to clean up message. I see this message in almost any command which is annoying 🙂

Cleanup: 2 tables [00:00, 4454.92 tables/s]

@mattseddon
Copy link
Member

We could change the Tqdm progress bars so that they disappear once completed. Jump to near the end of the following videos to see what I'm talking about:

Current state:

Screen.Recording.2025-01-06.at.3.38.50.pm.mov

Dropping progress bar on completion:

Screen.Recording.2025-01-06.at.3.37.45.pm.mov

Note: Even if we don't want to do this for all progress bars we could enable that option for cleanup progress.

@dmpetrov
Copy link
Member Author

dmpetrov commented Jan 6, 2025

@mattseddon good idea! I still have a feeling that we need more. But this looks like a great first step.

@mattseddon
Copy link
Member

We can reopen if the above change wasn't enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants