Weekly Digest (3 May, 2020 - 10 May, 2020) #1276

weekly-digest · 2020-05-10T11:03:44Z

Here's the Weekly Digest for iterative/dvc.org:

ISSUES

Last week 64 issues were created.
Of these, 48 issues have been closed and 16 issues are still open.

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

👍 #1213 3 years and 1.0 pre release, by dmpetrov
It received 👍 x0, 😄 x0, 🎉 x4 and ❤️ x0.

NOISY ISSUE

🔈 #1226 simplify code contributions + reviews by fully automating the dev setup., by nisarhassan12
It received 18 comments.

PULL REQUESTS

Last week, 40 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 5 pull requests were updated.
💛 #1269 ambassador blog draft, by andronovhopf
💛 #1266 doc: show-md on params/metrics diff, by skshetry
💛 #1262 [docs] add documentation on how to make a Pr with Gitpod., by nisarhassan12
💛 #1220 add support for math markdown, by nadalfederer
💛 #1074 get-started: full refactoring, by jorgeorpinel

MERGED PULL REQUEST

COMMITS

Last week there were 88 commits.
🛠️ [Add external doc sidebar links and replace "Changelog" with one. (#1273) * Add external doc sidebar links and replace "Changelog" with one.

Keep in mind that this is meant as a quick fix, and the current sidebar system
is likely to be overhauled in the future in a way that will have the
functionality, but not necessarily invoked with the same "type" syntax.

This branch allows the sidebar to have external links, and changes the
"Changelog" link at the end to be a link to the DVC GitHub.

Both the sidebar utils and component had to be changed to enable this- the
sidebar utils moreso as the "external" type bypasses previous logic entirely.
Anything without "external" set on it is treated the same, however.

The component change just treats external-typed entries a little differently by
setting target=_blank and preventing the href from having anything prepended
to it. The best solution is to move this out of the component level entirely,
but the best solution isn't the quickest and I've already mentioned big sidebar
changes are coming soon.

Remove target: null from non-external links.

My mistake, I thought null was the proper syntax here and I guess the linter
missed it.

Change existing changelog link on Community to point to releases
Change sidebar link to releases page
Change external link component choice to an if statement.

This is easier to read for most people, and also works better with linters.

Make sidebar "type" type field optional
Add an external link icon ID to the changelog sidebar item

I just grabbed an SVG we already had. It could use some work, but this is a
simple working implementation so it's worth pushing.

Use SVGR for sidebar external icon
Let findChildWithSource accept external links

Some parts of the application still use the sidebar.json helpers to determine
their links, and when attempting to do so on external-type links broke the
build.

This change fixes that situation, letting the findChildWithSource function
adapt to input that isn't internal.

It's a bit ugly, but this whole branch is a bit ugly. The sidebar overhaul
should take care of this more cleanly in the future.

Remove old changelog pages

I'm sorry, they look like they took some effort to write! But that's also the
reason we have to stop writing these and get rid of the old ones.

Change sidebar external icon link to match font color.

I made a new SVG based off the other one. It uses "currentColor" so it will take
on the color of its surrounding font by default, and also is fully transparent.

This new SVG is only used in the sidebar- other external link icons are still
the old hard-coded blue and white one.

Change external link url to be under url key
Add target="_blank" on externals by default.

This is done the same way as we already do rel="noopener noreferrer".
The change applies site-wide, but only to external links that don't specify a target.

target can still be overridden with anything, including a blank string.

Fix tests for new temporary sidebar logic
Move new icon to same dir as sidebar menu component](26130d4) by rogermparent
🛠️ Merge pull request #1271 from iterative/efiop-patch-2 docs: update: add -R|--recursive by jorgeorpinel
🛠️ Merge pull request #1275 from iterative/restyled/efiop-patch-2 Restyle docs: update: add -R|--recursive by jorgeorpinel
🛠️ Restyled by prettier by restyled-commits
🛠️ Update content/docs/command-reference/update.md by jorgeorpinel
🛠️ Update content/docs/command-reference/update.md by jorgeorpinel
🛠️ [Fix sidebar support for empty links (/doc/ trailing slash issue) (Fix sidebar support for empty links (/doc/ trailing slash issue) #1265) * Fix sidebar support for empty links

There was a hard-coded /doc/ prepended to every path before, but now we start
with /doc and add a second slash only if something comes after.

Adjust sidebar helpers to work with new PATH_ROOT](3431b82) by rogermparent
🛠️ docs: update: add -R|--recursive Fixes #1259 by efiop
🛠️ Merge pull request #1267 from iterative/efiop-patch-1 docs: remote: azure: don't use obsoleted url format by efiop
🛠️ docs: remote: azure: don't use obsoleted url format by efiop
🛠️ [Change how relative fragments are handled. (Change how relative fragments are handled. #1260) - Page-relative fragments (specifically, where the whole href starts with '#')
are now demoted to plain a links in our link wrapper.

The previous behavior that prepended to these links is now removed.
The link wrapper a fallback has been expanded upon with comments, and now
sets rel specifically on external links that don't already have it.](5c9a37d) by rogermparent
🛠️ Change tag page paths to be under /blog (#1261) Also change existing links to tag pages to use this new format by rogermparent
🛠️ [Change "docs/home" to "docs" (Change "docs/home" to "docs" #1257) * Move /doc/home to /doc
Change sidebar.json to point Home to the new url and keep the same label.
Change DocsPage model to generate home at new url.
Swap /doc -> /doc/home redirect to the other way around.
Change link component to allow empty strings that aren't undefined.

Re-add 307 code to swapped redirect
remove unnecessary falsy checks
remove old comment
Don't use '/' in doc home path creation
Change up redirects so new docs home never has a trailing slash
Remove old reversed redirect
Change instance of /doc/home to /doc
Fix slightly messed up redirects list](bce4d6a) by rogermparent
🛠️ download: update to 0.94.0 by efiop
🛠️ Merge pull request #1195 from iterative/2020-04-27 Regular updates (Apr 27) by jorgeorpinel
🛠️ Merge pull request #1186 from iterative/plots Plots by dmpetrov
🛠️ Merge branch 'master' into 2020-04-27 by jorgeorpinel
🛠️ Update content/docs/command-reference/plot/index.md by jorgeorpinel
🛠️ Update content/docs/command-reference/plot/show.md by jorgeorpinel
🛠️ Merge pull request #1258 from nilushancosta/patch-1 Add missing --local option in Azure instructions by jorgeorpinel
🛠️ docs: update GSoD blog post and remote add cmd ref by jorgeorpinel
🛠️ Add --local option by nilushancosta
🛠️ install: revert pre-release instructions change per https://github.com/iterative/dvc.org/pull/1195#pullrequestreview-407014113 by jorgeorpinel
🛠️ [Fix images in the RSS feed (Fix images in the RSS feed #1245) * Make root-relative links absolute in feed.

This runs the feed's htmlAst (from the remark transformer) through a processor
that changes all root-relative links (/example) into absolute
links (https://dvc.org/example), which is what many non-browser consumers of
HTML expect.

Finish getting things working with both processors.

This commit combines the root-relative rewriting with now-working image
unwrapping to deliver working images to the RSS feed!

The processor definition is also moved into the feed scope to take advantage of
the feed query to get the root URL.

Move the feed plugin back to its original space.

Since moving it out of gatsby-config won't be as simple as I thought, I decided
to leave it out of the scope of this branch.

Extract feed processor from gatsby-config to its own file

Also changed a bit around implementation:

Replaced rehype-urls, which depended on older rehype libs, with a local
implementation of the same thing for root-to-absolute linking.
The new feed util leans on the existing rehype-to-html function, and now the
new processor .uses less unified plugins as it only does AST processing.