Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document engine features #3506

Closed
5 tasks
casperdcl opened this issue May 4, 2022 · 7 comments
Closed
5 tasks

Document engine features #3506

casperdcl opened this issue May 4, 2022 · 7 comments
Labels
C: guide Content of /doc/user-guide type: discussion Requires active participation to reach a conclusion. website: eng-doc DEPRECATED JS engine for /doc

Comments

@casperdcl
Copy link
Contributor

casperdcl commented May 4, 2022

Are all features added to https://dvc.org/doc/user-guide/contributing/docs?

Missing things:

Really should document docs features as we implement them, even if it's just one line (or at least open follow-up issues to track).

/CC @iterative/docs @iterative/websites

@casperdcl casperdcl added website: eng-doc DEPRECATED JS engine for /doc C: guide Content of /doc/user-guide p1-current-quarter labels May 4, 2022
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) and removed p1-current-quarter website: eng-doc DEPRECATED JS engine for /doc labels May 11, 2022
@jorgeorpinel
Copy link
Contributor

Thanks for the summary. Documenting admonitions was a task in #3382 and for toggle/tabs in #2939 but indeed there are some other features we've always had and never documented so let's keep this one instead!

I'm just not sure whether to put it in the contrib guide or maybe in the README (and link there from the guide). Especially if we're extracting the docs engine into it's own repo cc @julieg18 WDYT

@jorgeorpinel jorgeorpinel added the p1-important Active priorities to deal within next sprints label May 11, 2022
@casperdcl
Copy link
Contributor Author

I'd say p1: contrib guide (that's where everything else is currently consolidated), p2: upgrade readme

@yathomasi
Copy link
Contributor

I'm just not sure whether to put it in the contrib guide or maybe in the README (and link there from the guide). Especially if we're extracting the docs engine into it's own repo

Personally, I would also say contrib guide.
It does make sense to have it on project README but we don't have a proper README and also the repo is private as of now.

@jorgeorpinel jorgeorpinel changed the title document docs features engine features May 21, 2022
@jorgeorpinel
Copy link
Contributor

What about contrib guides of other product doc sites that also use this engine e.g. cml.dev/doc of mlem.ai/doc, should they all have the same repeated info. about the doc engine features? I think it makes more sense to document them in iterative/gatsby-theme-iterative#17 and link from each contrib guide.

@jorgeorpinel jorgeorpinel added type: discussion Requires active participation to reach a conclusion. website: eng-doc DEPRECATED JS engine for /doc and removed p1-important Active priorities to deal within next sprints A: docs Area: user documentation (gatsby-theme-iterative) labels May 21, 2022
@jorgeorpinel jorgeorpinel changed the title engine features Document engine features Jun 2, 2022
@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 7, 2022

@yathomasi when is https://github.com/iterative/gatsby-theme-iterative going to be made public? If it's soon then we should:

Otherwise definitely should continue to consolidate everything in dvc.org/doc/contributing.

@yathomasi yathomasi reopened this Jun 7, 2022
@yathomasi
Copy link
Contributor

@yathomasi when is iterative/gatsby-theme-iterative going to be made public?

I think we can move ahead, and update the README(at least have some basic details) and make the repo public.

Here is a roadmap for our docs-engine theme. Now, we are about to step into phase-3. For the package to be easily usable for everyone, we need to generalize and optimize it more, which will take some time.

  • transfer this issue there

I think we can close this in favor of iterative/gatsby-theme-iterative#17

Specailly doc-style-guidelines-javascript-and-markdown portion

@casperdcl
Copy link
Contributor Author

ok moving to iterative/gatsby-theme-iterative#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: guide Content of /doc/user-guide type: discussion Requires active participation to reach a conclusion. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

No branches or pull requests

3 participants