Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll margin to anchor targets that need it #142

Open
rogermparent opened this issue Nov 30, 2022 · 0 comments
Open

Add scroll margin to anchor targets that need it #142

rogermparent opened this issue Nov 30, 2022 · 0 comments
Labels
p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately.

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Nov 30, 2022

scroll-pt-top on the body makes up for the sticky header exactly, and elements that want to have a little extra space can set scroll-mt to be used in addition.

Nice addition. I think we can add them to other linkers as well like details link, args link etc which also provide hash links beside headers.

Originally posted by @yathomasi in #140 (comment)

That PR added scroll-margin to docs headings, meaning that when navigated to via anchor (e.g. href="#heading-id") the docs headings will have some extra space above them instead of hugging the navbar. This Issue tracks adding scroll-margin to other elements throughout the site that would benefit the same way.

@rogermparent rogermparent changed the title Add scroll margin to id'ed elements that need it Add scroll margin to anchor targets that need it Nov 30, 2022
@rogermparent rogermparent added the p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately.
Projects
None yet
Development

No branches or pull requests

1 participant