Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidebar: better support index-like sources #77

Open
jorgeorpinel opened this issue Sep 14, 2022 · 1 comment
Open

sidebar: better support index-like sources #77

jorgeorpinel opened this issue Sep 14, 2022 · 1 comment
Labels
A: website Website development p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working.

Comments

@jorgeorpinel
Copy link

Removing source from things might break the "Edit on GitHub" links unless we update the sidebar logic to better accept them. Might not, but we need to make sure to check.

Originally posted by @rogermparent in iterative/dvc.org#3941 (comment)
@jorgeorpinel jorgeorpinel added the 🐛 type: bug Something isn't working. label Sep 14, 2022
@jorgeorpinel jorgeorpinel mentioned this issue Sep 14, 2022
Merged
@yathomasi
Copy link
Contributor

https://github.com/iterative/dvc.org/pull/3941/files#r970596286

@yathomasi yathomasi added A: website Website development p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: website Website development p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgeorpinel @yathomasi