Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginationWaitingView is not required #4

Open
geminiyellow opened this issue Jun 19, 2018 · 0 comments
Open

paginationWaitingView is not required #4

geminiyellow opened this issue Jun 19, 2018 · 0 comments

Comments

@geminiyellow
Copy link

@iwater

when i copy the example from README, got this warning,

Warning: Failed prop type: The prop `paginationWaitingView` is marked as required in `GiftedVirtualizedList`, but its value is `undefined`.

yes, in here, it is isRequired,

paginationWaitingView: PropTypes.func.isRequired,

but, where it used,

here:

paginationWaitingView: PropTypes.func,

and default:

static defaultProps = {
paginationWaitingView: noop,
}

so, i think you should remove the isRequired from API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant