Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eyetoy: frame size off by some bytes #55

Open
jackun opened this issue Oct 30, 2020 · 1 comment
Open

eyetoy: frame size off by some bytes #55

jackun opened this issue Oct 30, 2020 · 1 comment
Assignees

Comments

@jackun
Copy link
Owner

jackun commented Oct 30, 2020

} else if (s->mpeg_frame_offset < s->mpeg_frame_size) {

Off by sizeof(header1) + sizeof(header2)?

@Florin9doi
Copy link
Contributor

The total size (header1+2+mpeg_frame_data) is never calculated or used and mpeg_frame_offset is used to iterate in mpeg_frame_data, not in header1+2+mpeg_frame_data.
I can't find any issue. Maybe to verify that data_pk isn't larger than mpeg_frame_size at first step, but is unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants