Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebServiceCall decorator is bypassed #45

Open
byron-lambda opened this issue Sep 3, 2022 · 1 comment
Open

WebServiceCall decorator is bypassed #45

byron-lambda opened this issue Sep 3, 2022 · 1 comment

Comments

@byron-lambda
Copy link

byron-lambda commented Sep 3, 2022 •
edited
Loading

zeep creates types dynamically for ComplexType values. These new types have the class zeep.objects.ComplexType so isinstance(response, zeep.xsd.ComplexType) is always False, which effectively bypasses the WebServiceCall decorator here:

netsuite/netsuite/soap_api/decorators.py

Line 37 in 9d7bdb3

if not isinstance(response, zeep.xsd.ComplexType):

I'm not sure of the best way to resolve this. Is the isinstance test necessary?
@iloveitaly
Copy link
Collaborator

Can you submit a PR for this and we can work on it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iloveitaly @byron-lambda