Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing arbitrary pre-existing meshes #54

Open
Zireael07 opened this issue Mar 16, 2022 · 5 comments
Open

Allow editing arbitrary pre-existing meshes #54

Zireael07 opened this issue Mar 16, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@Zireael07
Copy link

Describe the bug
I added a mesh to the parent mesh instance, then added the ply editor. Ply editor continutes to behave as though the mesh was empty.

To Reproduce
See above

Expected behavior
Expected ply editor to allow me to edit the preexisting mesh.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@jarneson jarneson added the enhancement New feature or request label Mar 16, 2022
@jarneson jarneson changed the title Doesn't seem to recognize any meshes in the parent MeshInstance Allow editing arbitrary pre-existing meshes Mar 16, 2022
@jarneson
Copy link
Owner

This is definitely something we've looked at but it's a bit tricky. Godot Meshes expose tris only, so you end up with a triangulated mesh.

We also have stricter constraints on what a mesh is as well, in that it has to be a manifold. Not all Godot Meshes will be manifolds, so determining what to do in that case is tricky.

There's been some work on trying to get this to work in this branch: https://github.com/jarneson/godot-ply/tree/load-mesh-on-creation

@Zireael07
Copy link
Author

Yeah yeah, having used the plugin a bit I get the limitation, BUT adding the node underneath some existing mesh and seeing nothing happen is definitely weird.

For now, maybe add a print or a popup somewhere that explains clearly to the end user that any existing meshes will be ignored and overwritten by whatever ply editor spits out?

@fire
Copy link
Collaborator

fire commented Mar 18, 2022

I have a proposal.

If we can determine the pre-existing mesh is manifold we should be able to load it. Let's separate loading from make manifold.

Problems:

  1. loading
  2. make manifold

@fire
Copy link
Collaborator

fire commented Mar 26, 2022

We're now able to load manifold geometry meshes.

editor_screenshot_2022-03-26T132343

@jarneson
Copy link
Owner

Let's keep this issue around for "Arbitrary Meshes", which is a very long term goal.

#49 covers Manifold meshes only, which will be solved by the time we have a stable Godot 4 implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants