Skip to content
This repository has been archived by the owner on Oct 24, 2019. It is now read-only.

Support for inline JS macro expansions #5

Open
jarohen opened this issue Nov 25, 2014 · 1 comment
Open

Support for inline JS macro expansions #5

jarohen opened this issue Nov 25, 2014 · 1 comment

Comments

@jarohen
Copy link
Owner

jarohen commented Nov 25, 2014

It's having trouble with macros that expand to inline JS ( (js* ...) ) - need to handle this explicity.

This is a pretty important fix - (and ...) and (or ...) both expand to this.

@jarohen jarohen added the bug label Dec 1, 2014
@jarohen
Copy link
Owner Author

jarohen commented Dec 1, 2014

These seem to work. but sometimes (i.e. I can't figure out why) these leave warnings about undeclared vars that aren't actually undeclared.

e.g.

(f/el
  (let [a 2]
    (when (= a 2)
      ...)))

doesn't warn, but

(f/el
  (let [a 2]
    (when (and (= a 2)
               (= 4 4))
      ...)))

does. It then goes on to work at run-time.

Strange.

@jarohen jarohen removed the bug label Dec 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant