Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use hub access token directly in IDs #181

Open
jason0x43 opened this issue Aug 23, 2022 · 1 comment
Open

Don't use hub access token directly in IDs #181

jason0x43 opened this issue Aug 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jason0x43
Copy link
Owner

The hub access token is used to uniquely identify an instance of the Maker API to the integration. However, this means the access token can't be easily changed. Ideally, an integration instance should have a random unique ID, and should store the associated Maker API access token as a separate piece of configuration data.

@jason0x43 jason0x43 added the enhancement New feature or request label Aug 23, 2022
@jason0x43
Copy link
Owner Author

While I'm thinking of it: existing installs will need to copy the token value to a new "id" property in the config flow data. New installs will generate a random value for the id. The hub token will be associated with the config flow, but won't be used directly for device IDs (the new "id" property will).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant