-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valves unable to be controlled. #275
Comments
I added preliminary support in v0.9.29-pre0. Give that a try and let me know if it works. |
Some logging info would be helpful, but in the meantime I pushed v0.9.30 with some valve improvements. Give that a try and let me know if it works. |
Here's what i get after enabling debug and reloading the HE Integration: Logger: homeassistant.components.valve
Source: helpers/entity_platform.py:600
integration: Valve (documentation, issues)
First occurred: July 12, 2024 at 10:18:39 PM (3 occurrences)
Last logged: 2:59:36 PM
Error adding entity valve.sprinkler for domain valve with platform hubitat
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 600, in _async_add_entities
await coro
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 914, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1355, in add_to_platform_finish
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1000, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1126, in _async_write_ha_state
state, attr, capabilities, shadowed_attr = self.__async_calculate_state()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1061, in __async_calculate_state
state = self._stringify_state(available)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1006, in _stringify_state
if (state := self.state) is None:
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/valve/__init__.py", line 172, in state
reports_position = self.reports_position
^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/valve/__init__.py", line 149, in reports_position
raise ValueError(f"'reports_position' not set for {self.entity_id}.")
ValueError: 'reports_position' not set for valve.sprinkler. This error originated from a custom integration.
Logger: custom_components.hubitat.hub
Source: custom_components/hubitat/hub.py:484
integration: Hubitat (documentation, issues)
First occurred: July 12, 2024 at 10:19:06 PM (96 occurrences)
Last logged: 2:49:23 PM
Error handling event <Event device_id="1596" device_name="Sprinkler" attribute="rtt" value="-1217028967" unit="ms" description="Round-trip time is -1217028967 ms" type="None">: 'reports_position' not set for valve.sprinkler.
Error handling event <Event device_id="1596" device_name="Sprinkler" attribute="rtt" value="-1202462685" unit="ms" description="Round-trip time is -1202462685 ms" type="None">: 'reports_position' not set for valve.sprinkler.
Error handling event <Event device_id="1596" device_name="Sprinkler" attribute="rtt" value="-1201243503" unit="ms" description="Round-trip time is -1201243503 ms" type="None">: 'reports_position' not set for valve.sprinkler.
Error handling event <Event device_id="1596" device_name="Sprinkler" attribute="rtt" value="-1194157532" unit="ms" description="Round-trip time is -1194157532 ms" type="None">: 'reports_position' not set for valve.sprinkler.
Error handling event <Event device_id="1596" device_name="Sprinkler" attribute="battery" value="75" unit="%" description="None" type="physical">: 'reports_position' not set for valve.sprinkler. |
Thanks! I think I see what's wrong. Give v0.9.31 a try. |
v0.9.31 seems to have fixed the issue, for me at least. The valve shows up as a device and the controls work now! Thanks so much for this awesome integration! |
Works for me! |
Valves just show up asbinary sensors and don't allow for control.
Full hubitat device info:
The text was updated successfully, but these errors were encountered: