Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting a new release? Remove the deprecated parameter? #76

Open
nogweii opened this issue Jun 7, 2021 · 4 comments
Open

Cutting a new release? Remove the deprecated parameter? #76

nogweii opened this issue Jun 7, 2021 · 4 comments

Comments

@nogweii
Copy link
Collaborator

nogweii commented Jun 7, 2021

Thanks for merging my changes! What do you think about making a new release for the Ruby 3 compatibility?

It's also been long enough, I think, that the deprecation warning is probably no long necessary. (6 years!) Seems like as good as any time to remove it.

If both were to happen, is that a major version bump, or a minor bump? Not sure if you were following semantic versioning practices with this library.

@jasonlong
Copy link
Owner

My instinct says that it would still be a minor version bump since there's no functionality change, but an argument could probably be made for a bigger bump due to the Ruby 3 support. 🤔

Would you like me to add you as a maintainer for this project? I hacked the original version together years ago, but most of the follow-up refactoring was done by people with much stronger Ruby-fu than me. I recently added a note to the readme about the project being unmaintained, but if you (or someone else) wanted to help keep things up-to-date I'd happily remove that notice.

@nogweii
Copy link
Collaborator Author

nogweii commented Jun 9, 2021

I don't mind being added as a maintainer, though I'm content with the state of the library as it stands. I would focus on compatibility and bug fixes, rather than extending it further.

This is one of those lovely projects that are actually done. No need to push it further, in my mind.

@jasonlong
Copy link
Owner

This is one of those lovely projects that are actually done. No need to push it further, in my mind.

This is exactly how I see it as well. If you're willing to help keep things up-to-date once in a while in terms of Ruby updates, CI, etc. then that would be perfect. I've added you as a collaborator. Thanks in advance for your help. 🙇

@northeastprince
Copy link

@nogweii could you make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants