Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor/patch release cycle with bugfixes #1478

Closed
cristiprg opened this issue Sep 4, 2024 · 4 comments · Fixed by #1481
Closed

Minor/patch release cycle with bugfixes #1478

cristiprg opened this issue Sep 4, 2024 · 4 comments · Fixed by #1481
Labels
dependencies Pull requests that update a dependency file help-wanted question

Comments

@cristiprg
Copy link
Contributor

Hi! Do you have any plans to release another minor or patch version before the major upgrade to 3? There are a couple of smaller non-breaking fixes that would be great to have in, such as #1476 and #1465 which fixes this CVE. 🙏

@n2ygk
Copy link
Member

n2ygk commented Sep 4, 2024

I've pushed the date earlier and hope to publish the 3.0.0 version before then. I'm waiting on one or two last PR reviews. See https://github.com/jazzband/django-oauth-toolkit/milestone/35. It seems that oauthlib CVE can be dealt with now by upgrading oauthlib as the DOT 2.4.0 requirements are for oauthlib 3.1+ so 3.2.2+ is included in that. Given the dependency should be >=3.2.2 rather than >=3.2 as it was in #1465 it would be great if you were to submit a PR to push the version dependency to that level.

@n2ygk n2ygk added this to the 3.0.0 milestone Sep 4, 2024
@n2ygk n2ygk added help-wanted dependencies Pull requests that update a dependency file labels Sep 4, 2024
@cristiprg
Copy link
Contributor Author

Thanks @n2ygk! Here's the PR to bump oauthlib #1481

@cristiprg
Copy link
Contributor Author

cristiprg commented Sep 5, 2024

@n2ygk sorry, I may have not asked the question clearly. What I'm interested is having those two PRs before a major release with breaking changes, in for example DOT 2.4.1 or 2.5.

The motivation is that they are not breaking changes, so there is no need to only include them in a major release (bundled up with other breaking changes)

@n2ygk
Copy link
Member

n2ygk commented Sep 5, 2024 via email

@n2ygk n2ygk removed this from the 3.0.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help-wanted question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants