Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Django 4.x #598

Open
dshunfen opened this issue Apr 16, 2024 · 18 comments
Open

Support for Django 4.x #598

dshunfen opened this issue Apr 16, 2024 · 18 comments
Assignees

Comments

@dshunfen
Copy link

We're currently on the 3.1.0 stable version of django-polymorphic, which only explicitly states supporting Django 4.0. Is it safe to say this is true for all Django 4.x?

@bckohan
Copy link

bckohan commented Apr 17, 2024

The tests run on Django 4-5

py312-django40: OK (37.11=setup[19.24]+cmd[17.87] seconds)
py312-django41: OK (28.26=setup[11.27]+cmd[16.99] seconds)
py312-django42: OK (28.32=setup[11.27]+cmd[17.06] seconds)
py312-django50: OK (30.74=setup[11.39]+cmd[19.35] seconds)

So I think so yes. I'm using it in production on systems running Django 4.2 and 5.0

Seems like the whl classifiers and docs could be updated.

@leveille
Copy link

leveille commented Apr 18, 2024

Hey there. The pre release version (4.0a) tests up through Django 5. Version 3.1.0 (the most recent version available on pypi) does not test against 4.2/5 (unless it does and we just missed it). We just would like to know if others use 3.1 on Django 4.2 and if it's generally considered safe. So to be clear, you are using 3.1 on both Django 4.2 and 5 prod systems without issue? Thank you for your insight.

@bckohan
Copy link

bckohan commented Apr 18, 2024

Hey there. The pre release version (4.0a) tests up through Django 5. Version 3.1.0 (the most recent version available on pypi) does not test against 4.2/5 (unless it does and we just missed it). We just would like to know if others use 3.1 on Django 4.2 and if it's generally considered safe. So to be clear, you are using 3.1 on both Django 4.2 and 5 prod systems without issue? Thank you for your insight.

I am. Multiple production systems, different products running 3.1 on Django 4.2/5.0. No issues. Django 3.2 support is sunsetting now so it'd be a great time to release a version tested against supported Python/django versions.

@j-antunes
Copy link
Contributor

I was the one that created a pre release version 4.0a. I'm using it with django 4.1.13 and python 3.11. No issues. I have been using it for a while now. I would suggest for you try that version. Sorry that it's not updated with pip, but I don't have and have not been able to get access to be able to push to pip.

@du-song
Copy link

du-song commented May 3, 2024

Any plan to release 4.0 ?

@j-antunes
Copy link
Contributor

j-antunes commented May 3, 2024 via email

@akx
Copy link
Contributor

akx commented Jun 3, 2024

@j-antunes Any news on the PyPI front?

@vdboor I see you're still a maintainer of the package on PyPI, anything you could do to nudge this along? Cheers :)

@j-antunes
Copy link
Contributor

@akx - unfortunately no update :(

@nattyg93
Copy link

nattyg93 commented Jun 5, 2024

@j-antunes I couldn't find any transfer requests for django-polymorphic in https://github.com/pypi/support/issues. Have you made a PyPI transfer request?

It sounds like you've satisfied the prerequisites of contacting the original owner (vdboor - who is understandably busy with parenting), and there is the evidence in #548 that the original owner transferred the project to Jazzband.

You can open a transfer request here: https://github.com/pypi/support/issues/new?assignees=&labels=PEP+541&projects=&template=pep541-request.yml&title=PEP+541+Request%3A+PROJECT_NAME

@j-antunes
Copy link
Contributor

@nattyg93 - I was not aware of that. I submitted the request: pypi/support#4164

What I did was ask for help on element: https://app.element.io/#/room/#jazzband:matrix.org but no one very got back to me.

@akx akx mentioned this issue Jul 1, 2024
@bckohan
Copy link

bckohan commented Jul 18, 2024

This is starting to hit some of my projects. Wondering if anyone tried to contact @vdboor ? The update needed to make everything happy is trivial and already in git. We just need a pypi release.

@akx
Copy link
Contributor

akx commented Jul 18, 2024

This is hanging on @j-antunes changing the pypi/support#4164 request to be Jazzband-y, apparently: pypi/support#4164 (comment)

@j-antunes
Copy link
Contributor

@akx - Thanks for the ping. I updated the github issue to be the jazzband user. I think that's what I was supposed to do.

@vdboor
Copy link
Collaborator

vdboor commented Sep 16, 2024

@akx whoops! missed this one completely. I've resent the PyPI invite to the jazzband bot user.

@completementgaga
Copy link

I would be interested in using Django-polymorphic with Django 5.x in production, it would be so good to have the 4.0 version on pypi. By the way what about the tests of 4.0.0 alpha vs Django 5.1.2 ?

@akx
Copy link
Contributor

akx commented Oct 19, 2024

Pending a PyPI release, you can use git+https://github.com/jazzband/django-polymorphic.git@cfd49b26d580d99b00dcd43a02409ce439a2c78f in your requirements to use the current cfd49b2 version.

@alphatownsman
Copy link

Reading comments in pypi/support#4164 , it seems no blockers on their end any more? Anything we can help to push the release official?

@j-antunes
Copy link
Contributor

Thank you for the ping. I submitted this request to get a version out: jazzband/help#385

@j-antunes j-antunes self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants