Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Do not change .factorypath if it is already present #40

Open
WonderCsabo opened this issue Jun 26, 2015 · 7 comments
Open

Do not change .factorypath if it is already present #40

WonderCsabo opened this issue Jun 26, 2015 · 7 comments

Comments

@WonderCsabo
Copy link
Contributor

In some cases, projects needs a .factorypath, because it is customized. For example they could need an Eclipse plugin as an annotation processor in Eclipse builds, which cannot be added by m2e-apt.
I think m2e-apt could use a new GUI option: "Do not change factory path if it is already present". The default value can be false. @fbricon WDYT?

@WonderCsabo
Copy link
Contributor Author

To tell you an actual use-case:

this is a common setup for annotation processor development, you start a second eclipse instance and modify the test project in it, and if you use the AP as an Eclipse plugin in the second instance, you can nicely debug the AP in the first instance, use hot-code replacement, even JRebel etc.

@fbricon
Copy link
Member

fbricon commented Jun 26, 2015

Looks like some people want the opposite behavior (issue #28)

So why not disable m2e-apt for your project? it'll use whatever .factorypath you already have. You can use:

<m2e.apt.activation>disabled<m2e.apt.activation>

@WonderCsabo
Copy link
Contributor Author

@fbricon i still want to use m2e-apt for:

  • automatically enabling processing
  • generating processor options from POM.

@fbricon
Copy link
Member

fbricon commented Jul 1, 2015

on pto with extremely limited internet access. you can submit a pr and I will take a look in at most 2 weeks

@WonderCsabo
Copy link
Contributor Author

@fbricon that is cool, thanks for your response!

@WonderCsabo
Copy link
Contributor Author

@fbricon i am afraid i have to resign from this. I am really not familiar with Eclipse UI coding, and i do not have the time to learn it. Also, i have to admit, this issue is now lower priority for me than before.

@mickaelistria
Copy link

m2e-apt's code is now included in https://github.com/eclipse-m2e/m2e-core , please consider reporting issue to https://github.com/eclipse-m2e/m2e-core/issues if it's still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants