Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitialized constant ClassifierReborn::BayesRedisBackend #109

Closed
micmmakarov opened this issue Jan 10, 2017 · 8 comments
Closed

uninitialized constant ClassifierReborn::BayesRedisBackend #109

micmmakarov opened this issue Jan 10, 2017 · 8 comments

Comments

@micmmakarov
Copy link

micmmakarov commented Jan 10, 2017

When trying to connect redis backend.
redis_backend = ClassifierReborn::BayesRedisBackend.new {host: "10.0.1.1", port: 6380, db: 15}

(version 2.1.0)

@micmmakarov
Copy link
Author

image

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 11, 2017

So I should add a note that the readme on master is specific to master, 2.1.0 doesn't include the BayesRedisBackend. The readme for 2.1.0 is here. I need to better explain that in the readme. If you want to use the new backend, add gem 'classifier-reborn', github: 'jekyll/classifier-reborn' to your gemfile.

Let me know if that fixes the issue.

@ibnesayeed
Copy link
Contributor

This suggests that although the new changes are fully backward compatible, the scope of change warrants a second point release.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 12, 2017

You might be right, I'll look into it a bit more!

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 18, 2017

I'm going to do a 2.2.0 release soon

@Ch4s3 Ch4s3 closed this as completed Jan 18, 2017
@ibnesayeed
Copy link
Contributor

@Ch4s3: I'm going to do a 2.2.0 release soon

I would suggest to wait until documentation and tests are corrected to not use the magic method_missing style stuff and a deprecation warning is added.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 18, 2017 via email

@ibnesayeed
Copy link
Contributor

@Ch4s3: That was the plan

Created a ticket #140 to keep track of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants