Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running status is not rendered correctly. #38

Open
rahulr56 opened this issue Mar 4, 2019 · 6 comments
Open

Running status is not rendered correctly. #38

rahulr56 opened this issue Mar 4, 2019 · 6 comments
Labels
enhancement Improvement or new feature

Comments

@rahulr56
Copy link

rahulr56 commented Mar 4, 2019

Running status is not rendered correctly.

image

@thomas-dee
Copy link
Contributor

thomas-dee commented Mar 5, 2019

Well, this is actually intended behavior. "running" means:

  1. It is a running process -> the status is animated with a pulsing color
  2. The result is not clear yet -> the color is blue (and not red, green or yellow which would indicate a final result)
  3. The result of the previous run is indicated by the colored bar on the right side. In your example: brightgreen.

You can change the animated color (blue) using the query parameter animatedOverlayColor.

Examples: ...?animatedOverlayColor=brightgreen or ...?animatedOverlayColor=red

@rahulr56
Copy link
Author

rahulr56 commented Mar 5, 2019

@thomas-dee Yes, I do get the states. I am using the default versions for now.
The annoying part is the blue and green overlap in the image (highlighted in red)

image

@thomas-dee
Copy link
Contributor

@rahulr56 This overlap is also intended. As stated in my previous post, those overlaps indicate the previous run result.
If you find this "annoying" I might add another query parameter allowing to disable that.

@rahulr56
Copy link
Author

rahulr56 commented Mar 5, 2019

Yup, that would be great. Thanks 😊

@thomas-dee thomas-dee added the enhancement Improvement or new feature label Mar 6, 2019
@Makr91
Copy link

Makr91 commented May 29, 2019

Maybe put it on the left side instead?

@hogarthj
Copy link

An oddity I'm seeing here is that if I define the animatedOverlayColor on the query the image doesn't "settle" like a normal progress -> finished state ... instead it keeps on pulsing even when the job is complete.

Again, this is only if animatedOverlayColor is defined on the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

No branches or pull requests

4 participants