Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.login().then in the UsersCtrl never gets a response #5

Open
AaronV opened this issue Mar 9, 2014 · 2 comments
Open

Session.login().then in the UsersCtrl never gets a response #5

AaronV opened this issue Mar 9, 2014 · 2 comments

Comments

@AaronV
Copy link

AaronV commented Mar 9, 2014

Great example! However, I noticed that the Session.login().then function called from the UsersCtrl doesn't recieve a response object. I believe since the Session.login().then in the Sessions factory gets called first, it gets the response and doesn't send it to the additional .then() in the UsersCtrl.

This causes the login logic defined in UsersCtrl to think it failed, when in fact it succeeded.

@AaronV
Copy link
Author

AaronV commented Mar 9, 2014

At a cursory glance, this can be fixed by adding "return this;" in the end of the then(function() {}) blocks.

@jesalg
Copy link
Owner

jesalg commented Mar 9, 2014

Oh ok. You want to send me a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants